Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability] Split up observability-utils package #199801

Merged
merged 13 commits into from
Nov 13, 2024
Merged

[Observability] Split up observability-utils package #199801

merged 13 commits into from
Nov 13, 2024
+1,224 −98

Conversation

dgieselaar
Copy link
Member

@dgieselaar dgieselaar commented Nov 12, 2024 •
edited by kibanamachine
Loading

Split up observability-utils package in browser, common, server. Also made a small change to withSpan to automatically log operation times when the debug level for the logger is enabled.

dgieselaar and others added 10 commits November 12, 2024 15:32
@dgieselaar dgieselaar marked this pull request as ready for review November 13, 2024 10:47
@dgieselaar dgieselaar requested review from a team as code owners November 13, 2024 10:47
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

miloszmarcinkowski
miloszmarcinkowski reviewed Nov 13, 2024
View reviewed changes
...s/observability/observability_utils/observability_utils_browser/hooks/use_abortable_async.ts Outdated
@@ -43,6 +61,13 @@ export function useAbortableAsync<T>(
setError(undefined);
}

function handleError(err: Error) {
setError(err);
// setValue(undefined);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: commented code, was it a mistake?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! it is, at least the fact that the comment is still there.

@dgieselaar dgieselaar added v9.0.0 backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development v8.17.0 v8.18.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 13, 2024
@dgieselaar dgieselaar merged commit 11a752d into elastic:main Nov 13, 2024
56 checks passed
@dgieselaar dgieselaar deleted the observability-utils-pkg-split branch November 13, 2024 18:51
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.16, 8.18, 8.x

https://github.com/elastic/kibana/actions/runs/11823871605

@dgieselaar dgieselaar added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development labels Nov 13, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.18, 8.x

https://github.com/elastic/kibana/actions/runs/11823906372

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.15 Backport failed because of merge conflicts
❌ 8.16 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.16:
- [Security Solution] Removes unmaintained tests (#197408)
❌ 8.18 An unhandled error occurred. Please see the logs for details
❌ 8.x An unhandled error occurred. Please see the logs for details

Manual backport

To create the backport manually run:

node scripts/backport --pr 199801

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.18 The branch "8.18" does not exist
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 199801

Questions ?

Please refer to the Backport tool documentation

This was referenced Nov 14, 2024
Merged
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 14, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 199801 locally

@kibanamachine kibanamachine mentioned this pull request Nov 15, 2024
Merged
1 task
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 199801 locally

CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
@dgieselaar @kibanamachine @CAWilson94
[Observability] Split up observability-utils package (elastic#199801)
56eb145 
Split up observability-utils package in browser, common, server. Also
made a small change to `withSpan` to automatically log operation times
when the debug level for the logger is enabled.

---------

Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
@dgieselaar @kibanamachine @CAWilson94
[Observability] Split up observability-utils package (elastic#199801)
ab67ac3 
Split up observability-utils package in browser, common, server. Also
made a small change to `withSpan` to automatically log operation times
when the debug level for the logger is enabled.

---------

Co-authored-by: kibanamachine <[email protected]>
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 199801 locally

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 199801 locally

@dgieselaar dgieselaar mentioned this pull request Nov 20, 2024
Merged
@dgieselaar
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Nov 20, 2024
@dgieselaar
[Observability] Split up observability-utils package (elastic#199801)
f5a2c99 
Split up observability-utils package in browser, common, server. Also
made a small change to `withSpan` to automatically log operation times
when the debug level for the logger is enabled.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 11a752d)

# Conflicts:
#	.github/CODEOWNERS
dgieselaar added a commit that referenced this pull request Nov 20, 2024
@dgieselaar
[8.x] [Observability] Split up observability-utils package (#199801) (#…
b7d06a2 
…200886)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Observability] Split up observability-utils package
(#199801)](#199801)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dario
Gieselaar","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-13T18:51:42Z","message":"[Observability]
Split up observability-utils package (#199801)\n\nSplit up
observability-utils package in browser, common, server. Also\r\nmade a
small change to `withSpan` to automatically log operation times\r\nwhen
the debug level for the logger is
enabled.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"11a752da8751f447a083f050e0c4eeb85073fa56","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.17.0","v8.18.0"],"number":199801,"url":"https://github.com/elastic/kibana/pull/199801","mergeCommit":{"message":"[Observability]
Split up observability-utils package (#199801)\n\nSplit up
observability-utils package in browser, common, server. Also\r\nmade a
small change to `withSpan` to automatically log operation times\r\nwhen
the debug level for the logger is
enabled.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"11a752da8751f447a083f050e0c4eeb85073fa56"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199801","number":199801,"mergeCommit":{"message":"[Observability]
Split up observability-utils package (#199801)\n\nSplit up
observability-utils package in browser, common, server. Also\r\nmade a
small change to `withSpan` to automatically log operation times\r\nwhen
the debug level for the logger is
enabled.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"11a752da8751f447a083f050e0c4eeb85073fa56"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miloszmarcinkowski miloszmarcinkowski miloszmarcinkowski left review comments

@tonyghiani tonyghiani tonyghiani approved these changes

@viduni94 viduni94 viduni94 approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@crespocarlos crespocarlos crespocarlos approved these changes

@e40pud e40pud e40pud approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@dgieselaar @elasticmachine @kibanamachine @pgayvallet @e40pud @crespocarlos @shahzad31 @viduni94 @tonyghiani @miloszmarcinkowski